Added fitEither option to Image widget #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjvallarino
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
@Kyarigwo looks good! 👍
I think leaving the imageRepeat options as they are is fine since it matches the behavior for individual fitHeight/fitWidth.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new fit option to the image widget, 'fitEither', which will use either 'fitWidth' or 'fitHeight', whichever does not truncate any of the image. So it allows the image to be as large as possible, but keep the ratio.
I am not sure about is how to handle the imageRepeatX and imageRepeatY options. I think that they should be disabled, like for fitNone, but that will require more changes to the code.