Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public clients can't send a client secret #41

Closed
woosungchoi opened this issue Dec 23, 2016 · 13 comments
Closed

Public clients can't send a client secret #41

woosungchoi opened this issue Dec 23, 2016 · 13 comments

Comments

@woosungchoi
Copy link

woosungchoi commented Dec 23, 2016

I can view the following message.

access

But, After that

When ready, please enter the value of the code parameter (from the URL of the blank page) and press return

And I input below parameter

code=M7c53xxx7-x4xf-2867-3931-e0000000f0&lc=0000

and

Something went wrong, here is the API response:
{"error":"invalid_request","error_description":"Public clients can't send a client secret."}

Plus

App ID has always dash. So readme file need to update.

thx.

@weismat
Copy link

weismat commented Dec 26, 2016

Same issue here...
Also removing the data of the & does not make a difference.

./onedrive-authorize: line 14: ./libs/json/bash-json-parser: No such file or directory
Something went wrong, here is the API response:
{"error":"invalid_request","error_description":"Public clients can't send a client secret."}

@fkalis
Copy link
Owner

fkalis commented Dec 26, 2016

@Wsget: You must only enter the M7c53xxx7-x4xf-2867-3931-e0000000f0 part. If you did, we have to take a look at your registered apps settings.

@weismat: It seems like you are missing the submodule bash-json-parser. Did you checkout the repository with the --recursive parameter as stated in the Readme file?

@weismat
Copy link

weismat commented Dec 26, 2016

I copied the zip directory and the file was not included. I created in now manually and it is good to go. I am stuck now though at uploading files and always receive "Folder structure created, no files uploaded."

@MatthiasWeiser
Copy link

weismat with my company login.
./onedrive-upload -r onedrive-upload test
No refresh token received from API. Please try again or re-authorize.
No refresh token received from API. Please try again or re-authorize.
No refresh token received from API. Please try again or re-authorize.
An error has occurred while uploading 'onedrive-upload' (Code: )

@woosungchoi
Copy link
Author

./onedrive-authorize

Please open the following URL in your browser and follow the steps until you see a blank page:
https://login.live.com/oauth20_authorize.srf?client_id=1xxx0000-000x-0000-0000-0xxx000xx00x&scope=wl.offline_access%20onedrive.readwrite&response_type=code&redirect_uri=https://login.live.com/oauth20_desktop.srf

When ready, please enter the value of the code parameter (from the URL of the blank page) and press return
xx00xxx00-000x-00xx-x000-000000x00x00
Something went wrong, here is the API response:
{"error":"invalid_request","error_description":"Public clients can't send a client secret."}

And my apps settings

Authentication config

export api_client_id="0xxx0000-000x-0000-0000-0xxx000xx00x"
export api_client_secret="00XX0X00X000X0X0000X000000X000X000X0XX00"

api_client_secret is Application Secrets - Private Key. Is that right?

and api_client_id is Application Id. Is that right?

@fkalis
Copy link
Owner

fkalis commented Dec 28, 2016

App ID has always dash. So readme file need to update.

If your App ID contains dashes, you have created the wrong (unsupported) application type. Please take a look at this comment.

@woosungchoi
Copy link
Author

When I go into this link

https://apps.dev.microsoft.com/#/appList

00_link

and click add an app

01_add

and after create application

02_view

An ID with a dash is created.

There is no "create your application in the Live SDK applications section" option.

I mean there is no other option.

So, take a look at this problem plz.

@fkalis
Copy link
Owner

fkalis commented Dec 29, 2016

Please use the link from the README file and try again: https://apps.dev.microsoft.com/#/appList/create/sapi

This should automatically ask for an application name without clicking Add an app.

@woosungchoi
Copy link
Author

Ok. I got it.

But when I upload file, always receive

"Folder structure created, no files uploaded"

message.

fkalis added a commit that referenced this issue Dec 29, 2016
@fkalis
Copy link
Owner

fkalis commented Dec 29, 2016

Bug "Folder structure created, no files uploaded" found and fixed.

@weismat
Copy link

weismat commented Dec 29, 2016

Thank you very much for your quick help and support.

@WSGVET
Copy link

WSGVET commented Dec 29, 2016

Thx so much.

I will try.!

@woosungchoi
Copy link
Author

It works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants