Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismiss / dismissAll for TS #104

Closed
keljond27 opened this issue Dec 14, 2017 · 2 comments
Closed

dismiss / dismissAll for TS #104

keljond27 opened this issue Dec 14, 2017 · 2 comments
Assignees
@fkhadra
Labels
bug

Comments

@keljond27
Copy link

TS interface for toast doesn't allow for dismiss argument to be optional -
current: dismiss(toastId: number): void;
should be: dismiss(toastId?: number): void;

This would allow user to forgo using toastId and enable dismissing all active toast messages
@fkhadra fkhadra self-assigned this Dec 14, 2017
@fkhadra fkhadra added the bug label Dec 14, 2017
@fkhadra
Copy link
Owner

fkhadra commented Dec 14, 2017

Thank @keljond27 for reporting the issue. It's fixed and will be live soon.

fkhadra added a commit that referenced this issue Dec 14, 2017
@fkhadra
Fix issue #104: Correct TS definition
b35add2
@fkhadra
Copy link
Owner

fkhadra commented Dec 14, 2017

@keljond27 the new release is live 🚀

@fkhadra fkhadra closed this as completed Dec 14, 2017
vasiliydolmatov pushed a commit to vasiliydolmatov/react-toastify that referenced this issue Apr 2, 2019
@fkhadra
Fix issue fkhadra#104: Correct TS definition
50c2da7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkhadra fkhadra

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkhadra @keljond27