Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add processor to enrich IP information #303

Merged
merged 12 commits into from
Feb 14, 2023
Merged

add processor to enrich IP information #303

merged 12 commits into from
Feb 14, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Jan 27, 2023

This adds a processor to enrich information to ips in the event.

ToDo:

  • implement _apply_rules
  • add failure testcases
  • add testcases for multiple ip fields
  • add testcases for ip field with list of ips
  • add documentation for rule.py
  • add jupyther notebook

@ekneg54 ekneg54 self-assigned this Jan 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 91.11% // Head: 91.23% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (b2aae09) compared to base (827bec8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   91.11%   91.23%   +0.12%     
==========================================
  Files         117      119       +2     
  Lines        8124     8139      +15     
==========================================
+ Hits         7402     7426      +24     
+ Misses        722      713       -9     
Impacted Files Coverage Δ
logprep/abc/processor.py 100.00% <100.00%> (ø)
logprep/processor/calculator/processor.py 100.00% <100.00%> (ø)
logprep/processor/ip_informer/processor.py 100.00% <100.00%> (ø)
logprep/processor/ip_informer/rule.py 100.00% <100.00%> (ø)
logprep/registry.py 100.00% <100.00%> (ø)
logprep/_version.py 39.71% <0.00%> (+2.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ekneg54 ekneg54 requested a review from sashs February 13, 2023 15:08
@ekneg54 ekneg54 added the enhancement New feature or request label Feb 13, 2023
@ekneg54 ekneg54 marked this pull request as ready for review February 13, 2023 15:15
@ekneg54 ekneg54 merged commit e62d073 into main Feb 14, 2023
@ekneg54 ekneg54 deleted the dev-add-ip-informer branch March 10, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants