Improve registry performance #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- import logprep components only when needed
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 91.46% 91.54% +0.07%
==========================================
Files 121 121
Lines 8522 8492 -30
==========================================
- Hits 7795 7774 -21
+ Misses 727 718 -9
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ekneg54
reviewed
Mar 30, 2023
There was a problem hiding this comment.
I have a bad feeling with this. From developer perspective it is much more to write now. From a security perspective I'm not fine with importing from arbitrary strings and from performance perspective as you say it has not a big impact.
Is there another perspective I'm not aware of for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a more dynamic importing of the logprep components.
Previously every logprep start imported literally all components, even those which weren't used due to the configuration. This lead to an unnecessary overhead for importing classes and their corresponding used classes/methods (e.g elasticsearch, opensearch, or hyperscan,...) even though they were unimportant for the configured run.
This is not a huge performance improvement, but it should still improve the startup a little bit.