Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grokker processor #363

Merged
merged 52 commits into from
Apr 21, 2023
Merged

add grokker processor #363

merged 52 commits into from
Apr 21, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Apr 3, 2023

  • reimplement grok with updated default ecs conform grok patterns
  • apply adaption GrokWraper to own grok implementation
  • add rule with tests
  • add processor with tests
    • add getter logic to additional grok patterns dir (we should be able to serve this via http)
    • add oniguruma syntax support
  • add documentation
  • add jupyther notebook example

@ekneg54 ekneg54 self-assigned this Apr 3, 2023
@ekneg54 ekneg54 force-pushed the dev-add-grokker-processor branch 4 times, most recently from c0afa17 to a841deb Compare April 17, 2023 11:43
Copy link
Collaborator

@gigallucci gigallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekneg54 ekneg54 requested a review from sashs April 19, 2023 07:59
@ekneg54 ekneg54 marked this pull request as ready for review April 19, 2023 13:14
logprep/processor/grokker/processor.py Show resolved Hide resolved
logprep/processor/grokker/processor.py Outdated Show resolved Hide resolved
logprep/processor/grokker/rule.py Outdated Show resolved Hide resolved
logprep/processor/grokker/rule.py Show resolved Hide resolved
logprep/util/grok/grok.py Outdated Show resolved Hide resolved
logprep/util/grok/grok.py Show resolved Hide resolved
logprep/util/grok/grok.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Patch coverage: 97.84% and project coverage change: +0.26 🎉

Comparison is base (735e10d) 91.93% compared to head (fa38813) 92.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   91.93%   92.20%   +0.26%     
==========================================
  Files         127      130       +3     
  Lines        9007     9241     +234     
==========================================
+ Hits         8281     8521     +240     
+ Misses        726      720       -6     
Impacted Files Coverage Δ
logprep/util/pre_detector_rule_matching_tester.py 0.00% <0.00%> (ø)
logprep/processor/grokker/processor.py 96.61% <96.61%> (ø)
logprep/util/grok/grok.py 98.31% <98.31%> (ø)
logprep/framework/pipeline.py 95.02% <100.00%> (+0.02%) ⬆️
logprep/processor/dissector/rule.py 100.00% <100.00%> (ø)
logprep/processor/grokker/rule.py 100.00% <100.00%> (ø)
logprep/processor/processor_strategy.py 100.00% <100.00%> (ø)
logprep/registry.py 100.00% <100.00%> (ø)
logprep/util/auto_rule_tester/auto_rule_tester.py 86.65% <100.00%> (ø)
...rep/util/auto_rule_tester/grok_pattern_replacer.py 94.06% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ekneg54 ekneg54 requested a review from sashs April 21, 2023 08:55
@ekneg54 ekneg54 merged commit 4e37159 into main Apr 21, 2023
@ekneg54 ekneg54 deleted the dev-add-grokker-processor branch June 6, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants