Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify quickstart #373

Merged
merged 7 commits into from
Apr 24, 2023
Merged

simplify quickstart #373

merged 7 commits into from
Apr 24, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Apr 20, 2023

  • Rewrite quickstart setup:
    • Remove logstash, replace elasticsearch by opensearch and use logprep opensearch connector to stick to reference architecture
    • Use kafka without zookeeper and switch to bitnami container images

@ekneg54 ekneg54 self-assigned this Apr 20, 2023
@ekneg54 ekneg54 requested a review from herrfeder April 20, 2023 12:56
@ekneg54 ekneg54 marked this pull request as ready for review April 20, 2023 12:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.25 🎉

Comparison is base (7cfafc3) 91.94% compared to head (7deebad) 92.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   91.94%   92.20%   +0.25%     
==========================================
  Files         127      130       +3     
  Lines        9009     9244     +235     
==========================================
+ Hits         8283     8523     +240     
+ Misses        726      721       -5     

see 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@herrfeder herrfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opensearch ✔️ looks good, as you removed opensearch security completely for this test deployment, which is legitimate for this purpose, there is nothing that is missing that would otherwise do

Kafka ❌ As I pointed out in the comment, for Kafka there seems to be missing a Environment Variable. I don't know if I did something wrong or maybe this requirement was baked into the image recently but it won't run this way on my machine.

quickstart/docker-compose.yml Show resolved Hide resolved
@ekneg54
Copy link
Collaborator Author

ekneg54 commented Apr 24, 2023

indeed they come with a newer version the last days. I fixed the NODE ID issue and pinned the kafka version to ensure, this never happens again.

@ekneg54 ekneg54 requested a review from herrfeder April 24, 2023 11:05
Copy link
Collaborator

@herrfeder herrfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logprep config doesn't resolve correctly because of the mounting path in logprep container

quickstart/docker-compose.yml Show resolved Hide resolved
@herrfeder
Copy link
Collaborator

please see my suggestion for the readme change in my commit in this branch.

@ekneg54
Copy link
Collaborator Author

ekneg54 commented Apr 24, 2023

thx for your commit. I removed zookeeper from readme too as the point for this simplification was to remove zookeeper from the configuration

@ekneg54 ekneg54 merged commit 39e8323 into main Apr 24, 2023
@ekneg54 ekneg54 deleted the dev-simplify-quickstart branch June 6, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants