-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify quickstart #373
simplify quickstart #373
Conversation
ekneg54
commented
Apr 20, 2023
•
edited
Loading
edited
- Rewrite quickstart setup:
- Remove logstash, replace elasticsearch by opensearch and use logprep opensearch connector to stick to reference architecture
- Use kafka without zookeeper and switch to bitnami container images
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 91.94% 92.20% +0.25%
==========================================
Files 127 130 +3
Lines 9009 9244 +235
==========================================
+ Hits 8283 8523 +240
+ Misses 726 721 -5 see 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opensearch ✔️ looks good, as you removed opensearch security completely for this test deployment, which is legitimate for this purpose, there is nothing that is missing that would otherwise do
Kafka ❌ As I pointed out in the comment, for Kafka there seems to be missing a Environment Variable. I don't know if I did something wrong or maybe this requirement was baked into the image recently but it won't run this way on my machine.
indeed they come with a newer version the last days. I fixed the NODE ID issue and pinned the kafka version to ensure, this never happens again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logprep config doesn't resolve correctly because of the mounting path in logprep container
please see my suggestion for the readme change in my commit in this branch. |
thx for your commit. I removed zookeeper from readme too as the point for this simplification was to remove zookeeper from the configuration |