added degree for sin(), cos() and tan() #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- any documentation has not been updated - takes a 'isRadian' parameter that's by default true, if nothing's been passed as 'isRadian' - if 'isRadian' is false, the function is carried out in degrees - changes have been made in the 'parse' method in 'parser.dart'
|
This fix has a bug. Gives wrong outputs in scenarios like these: |
|
Hi @danger-ahead, thanks for trying to contribute this change to math-expressions. I recommend adding some unit tests next time to verify the expected behaviour. Let me know if you still want to work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33
any documentation has not been updated
takes a 'isRadian' parameter that's by default true, if nothing's been passed as 'isRadian'
if 'isRadian' is false, the function is carried out in degrees
changes have been made in the 'parse' method in 'parser.dart'
Tested and found to be working as expected.