Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#128 moved internal impl to detail dir/namespace #131

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Oct 9, 2023

To keep consistency of public fkYAML library APIs as much as possible, implementations for internal use only have been moved to include/fkYAML/detail directory.
Such implementations are subject to changes without notices, and thus have no gurantee of consistency even if the fkYAML library provides its backward compatibility.
Those moved implementations will still be listed in the fkYAML release package because they are still necessary for a project which uses the fkYAML library.

Furthermore, part of doxygen comments have been fixed to make it up to day.

See #128 for more details.

@fktn-k fktn-k added this to the Release v0.1.0 milestone Oct 9, 2023
@fktn-k fktn-k self-assigned this Oct 9, 2023
@fktn-k
Copy link
Owner Author

fktn-k commented Oct 9, 2023

To fix failure in GA workflow, the command for clang-format has been moved from CMakeLists.txt to Makefile.
This would be reasonable since clang-format does not require build options for a header-only library.

@fktn-k fktn-k merged commit e954b8a into develop Oct 9, 2023
103 checks passed
@fktn-k fktn-k deleted the feature/128_move_internal_impl branch October 9, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant