Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#302 Fixed parse error on alias mapping keys #303

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Mar 31, 2024

This PR addresses the issue #302 by the following changes:

  • The handling of alias nodes has been fixed in both the parser and the lexer since they didn't consider alias mapping keys.
  • The deserialization of scalar nodes has been changed to correctly parse anchor/alias nodes.
  • The extraction of anchor names has been changed since some invalid patterns were not correctly detected.
  • The test suite has been updated to validate the above changes.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Mar 31, 2024
@fktn-k fktn-k added this to the Release v0.3.3 milestone Mar 31, 2024
@fktn-k fktn-k self-assigned this Mar 31, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit d6a2e9f5f5c47372044fff0e3c54979dfcef2c15.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr303.zip
ID 1372482939
URL https://github.com/fktn-k/fkYAML/actions/runs/8497009204/artifacts/1372482939

@fktn-k fktn-k linked an issue Mar 31, 2024 that may be closed by this pull request
2 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8497009204

Details

  • 71 of 71 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8492754549: 0.0%
Covered Lines: 3054
Relevant Lines: 3054

💛 - Coveralls

@fktn-k fktn-k merged commit 52bff7e into develop Mar 31, 2024
144 checks passed
@fktn-k fktn-k deleted the bugfix/302_parse_alias_mapping_keys branch March 31, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse error on an alias node key
2 participants