Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse error on block sequences with child flow style container nodes #332

Merged
merged 5 commits into from
May 1, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 1, 2024

This PR has fixed parse errors which the current parser emits on a block sequence containing child flow style containers (either sequence and/or mapping), like the following valid YAML snippet (based on the official YAML test suite YD5X):

# child flow sequences
- [username, identifier, score]
- [booker12, 9012      , 61.25]
- [grey07  , 2070      , 84.50]

# child flow mappings
- {foo: false, null: 123}
- {true: 3.14, bar: [0x30,0o30]}

While modifying implementation to fix the above issue, the way of managing parse contexts has also been corrected by adding the variation of parse context states.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label May 1, 2024
@fktn-k fktn-k added this to the Release v0.3.6 milestone May 1, 2024
@fktn-k fktn-k self-assigned this May 1, 2024
Copy link

github-actions bot commented May 1, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 725bb6c3b560a9c4797223b094f5b4541a6c76d4.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr332.zip
ID 1465123755
URL https://github.com/fktn-k/fkYAML/actions/runs/8915291691/artifacts/1465123755

@coveralls
Copy link

coveralls commented May 1, 2024

Pull Request Test Coverage Report for Build 8915291691

Details

  • 123 of 123 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8899528587: 0.0%
Covered Lines: 3574
Relevant Lines: 3574

💛 - Coveralls

@fktn-k fktn-k merged commit 9cbff17 into develop May 1, 2024
162 checks passed
@fktn-k fktn-k deleted the fix_parse_child_flow_style_containers branch May 1, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants