Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support flow line folding for single/double quoted scalars #344

Merged
merged 3 commits into from
May 19, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 19, 2024

This PR has added the feature of deserializing the flow line folding for single/double quoted scalars with the following restrictions:

  • The flow line folding is being allowed for implicit keys despite that it's explicitly forbidden in the YAML specification. This is because of the lack of implementation to determine if scalars are implicit keys or not but such a logic is going to be implemented and the folding will become not allowed in the future.
  • The flow line folding for plain scalars is not yet supported since the deserialization feature is not yet ready for that feature. It will, however, surely be supported in the future. Until the feature gets ready, please make such a scalar be either single or double quoted.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the new feature new feature possibly with public API changes label May 19, 2024
@fktn-k fktn-k added this to the Release v0.3.8 milestone May 19, 2024
@fktn-k fktn-k self-assigned this May 19, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 974f15c8c279c5d54f0daa7d8aa7b50a8e74f8a9.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr344.zip
ID 1516970888
URL https://github.com/fktn-k/fkYAML/actions/runs/9147086497/artifacts/1516970888

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9147086497

Details

  • 63 of 63 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9144792364: 0.0%
Covered Lines: 3752
Relevant Lines: 3752

💛 - Coveralls

@fktn-k fktn-k merged commit b2a2fe3 into develop May 19, 2024
160 checks passed
@fktn-k fktn-k deleted the feature/support_flow_line_folding branch May 19, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature possibly with public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants