Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parssing multiple YAML documents #362

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jun 15, 2024

This PR has added the new feature of parsing multiple YAML documents like the following YAML snippet:

%YAML 1.2
---
foo: bar
...
%TAG ! tag:com.example,2000:
---
baz: 123
...

The newly implemented fkyaml::basic_node::deserialize_docs() function deserializes the contents of the above snippet into two basic_node objects.
See the updated API documentation for more details.

Note that the serialization can't properly handle multiple YAML documents yet, which will be implemented in a coming PR.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the new feature new feature possibly with public API changes label Jun 15, 2024
@fktn-k fktn-k added this to the Release v0.3.10 milestone Jun 15, 2024
@fktn-k fktn-k self-assigned this Jun 15, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit ed9990a380923a8b098b571b8bfecfe1c85a9c6f.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr362.zip
ID 1604857378
URL https://github.com/fktn-k/fkYAML/actions/runs/9528817519/artifacts/1604857378

@coveralls
Copy link

coveralls commented Jun 15, 2024

Pull Request Test Coverage Report for Build 9528817519

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9527168210: 0.0%
Covered Lines: 3915
Relevant Lines: 3915

💛 - Coveralls

@fktn-k fktn-k merged commit 5bb5a4f into develop Jun 15, 2024
178 checks passed
@fktn-k fktn-k deleted the support_parse_multi_docs branch June 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature possibly with public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants