Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serializing multiple YAML docs #363

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jun 16, 2024

This PR has added the new support of serializing multiple YAML documents by implementing the fkyaml::basic_node::serialize_docs() function.
It accepts a vector of basic_node objects like the fkyaml::basic_node::deserialize_docs() function returns, and returns a string as the serialization result with separation lines (...) between documents.
See the updated API documentation for details about the function.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the new feature new feature possibly with public API changes label Jun 16, 2024
@fktn-k fktn-k added this to the Release v0.3.10 milestone Jun 16, 2024
@fktn-k fktn-k self-assigned this Jun 16, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 9f68f740c1d9f867aed5ca27d06b1522bf06e2b2.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr363.zip
ID 1605433593
URL https://github.com/fktn-k/fkYAML/actions/runs/9532608170/artifacts/1605433593

@coveralls
Copy link

coveralls commented Jun 16, 2024

Pull Request Test Coverage Report for Build 9532608170

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9528914558: 0.0%
Covered Lines: 3928
Relevant Lines: 3928

💛 - Coveralls

@fktn-k fktn-k merged commit 8aa3e50 into develop Jun 16, 2024
178 checks passed
@fktn-k fktn-k deleted the support_serialize_multiple_docs branch June 16, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature possibly with public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants