Update ui.js #216
Update ui.js #216
Conversation
Enable to add ID for search automcplete in order to enable more than one search element on same page
static/org.openpsa.widgets/ui.js
Outdated
| config = {field: defaults.field, current: config}; | ||
| } | ||
|
|
||
| Object.assign(defaults, config); |
There was a problem hiding this comment.
that looks wrong. According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign this copies from config to defaults
There was a problem hiding this comment.
I did that at the begining, and it didn't work. this works as expected.
There was a problem hiding this comment.
var defaults = {a: 1, b: 2},
config = {b: 4};
Object.assign(defaults, config);
console.log(config);Output:
{b: 4}No default has been merged into config
|
|
||
| var field = $('#org_openpsa_search_query'), | ||
| var field = $(config.field), |
There was a problem hiding this comment.
what about line 157/158? There's also hardcoded selectors down there
assign config to result of object.assign, in order to preserve all keys
Change id to class, in order to avoid duplicate id in case multiple search elements will be display on same page and adjust selectors
| li_class += ' current'; | ||
| enable_provider(provider); | ||
| } | ||
|
|
||
| $('<li class="' + li_class + '">' + provider.placeholder + '</li>') | ||
| .data('provider', provider) | ||
| .click(function() { | ||
| var old_item = $('#org_openpsa_search_providers .current'), | ||
| query = $('#org_openpsa_search_query'); | ||
| var old_item = form.find('.org_openpsa_search_providers .current'); |
There was a problem hiding this comment.
if this changes from id to classname, this also has to change: https://github.com/flack/openpsa/search?q=org_openpsa_search_trigger
Change id to class selector
Solve css issur caused from changing selctors from id to class
| @@ -432,7 +432,8 @@ ul.org_openpsa_search_providers | |||
| box-shadow: .1em .2em .5em rgba(0, 0, 0, .3); | |||
| } | |||
|
|
|||
| ul.org_openpsa_search_providers li | |||
| form[id^="org_openpsa_search_"] ul.org_openpsa_search_providers li, | |||
| #org_openpsa_search_form ul.org_openpsa_search_providers li | |||
There was a problem hiding this comment.
How about #content-menu ul.org_openpsa_search_providers li instead?
There was a problem hiding this comment.
I mean, instead of two separate selectors. the effect should be the same, no?
There was a problem hiding this comment.
the first doesn't work with container contet-menu, it is for pages that hast different form id, and don't containt menu-content id
Enable to add ID for search automcplete in order to enable more than one search element on same page