Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appium get all attributes; get attribute or attributes by find parameters #205

Closed
wants to merge 11 commits into from

Conversation

ncalaway
Copy link
Collaborator

Making this PR now because in addition to getting multiple attributes and getting an attribute by find parameters, this also fixes the _getAttribute function on AppiumElement.

Copy link
Collaborator

@jasonbyrne jasonbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need to add a new depdency. Flagpole can already parse XML with cheerio. We have XML scenario types already

@ncalaway
Copy link
Collaborator Author

We should not need to add a new depdency. Flagpole can already parse XML with cheerio. We have XML scenario types already

I have not been able to get Cheerio to give me the results I want. I'm not able to get it to find elements nested deeper than the first layer. Closing this as it's supposed to be a nice to have. I'll add the fix in this branch directly on the appium branch.

@ncalaway ncalaway closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants