Appium fixes #209
Merged
Appium fixes #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed Appium Scenario to create session on instantiating an AppiumScenario object. This may or may not be the way we ultimately use, but before doing this the AppiumScenario would call
.open()in the middle of instantiating the AppiumResponse object, which caused a crash.I also changed AppiumElement click behavior to do single click calling
.click()on Appium server when not passing in an opts argument. I feel this is more natural than having this specific behavior for passing in a click count of one. What if we want to do a single longpress? It is not possible if the Appium native click is called every time we pass in a click count of 1. Also, code which calls.click()on an element will no longer break due to this change.Finally, I changed AppiumElement.getAttribute() to return a Promise. It was returning an unresolved promise before. I meant to fix this in another PR, but the fix got lost in the mix.