Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3484: Refactor euclidean distance calculation #3485

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

sheldon-roberts
Copy link
Contributor

#3484

Optimizes the euclidean distance method.

Copy link

@mattb-zip mattb-zip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a big improvement. Don't see any reason that tensors would be calculated in a non-parallel way

@alanakbik
Copy link
Collaborator

@sheldon-roberts thanks for adding this!

@plonerma can you test/review the PR?

Copy link
Collaborator

@plonerma plonerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason either ;) Thanks for the improvement!

@alanakbik alanakbik merged commit afedf3c into flairNLP:master Jul 3, 2024
1 check passed
@alanakbik
Copy link
Collaborator

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants