Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar for WARC file processing #542

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Jun 20, 2024

This PR:

  • adds a bar to display the progression of WARC file processing
  • add a parameter to CCNewsCrawler to disable progress bars

@MaxDall MaxDall requested a review from addie9800 June 20, 2024 17:59
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Thanks for adding it. There is one question I have though: do you think it's easily possible to force the progressbar to be at the bottom of the output? Because if there are things printed to stdout, it gets lost pretty quickly. I tried playing around with it a bit, but there doesn't seem to be a quick fix.

@MaxDall
Copy link
Collaborator Author

MaxDall commented Jun 27, 2024

do you think it's easily possible to force the progressbar to be at the bottom of the output?

No, I can't think of an easy or even practical solution for this. An alternative is always to disable tqdm.
Maybe this can help?

@addie9800
Copy link
Collaborator

do you think it's easily possible to force the progressbar to be at the bottom of the output?

No, I can't think of an easy or even practical solution for this. An alternative is always to disable tqdm. Maybe this can help?

I tried it, but it doesn't really work, maybe because of the multiprocessing, I'm not sure. Disabling wouldn't help either, since I thought it would be nice to always have the current progess visible, even if logging is set to a broader level or the usage involves printing. But it's also not that important.

@MaxDall MaxDall merged commit de1fc8e into master Jun 27, 2024
4 checks passed
@MaxDall MaxDall deleted the add-optional-tqdm-to-cc-news-crawler branch July 2, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants