Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add avoid_final_parameters, depend_on_referenced_packages, unnecessary_to_list_in_spreads #1927

Merged
merged 4 commits into from
Sep 20, 2022
Merged

feat: Add avoid_final_parameters, depend_on_referenced_packages, unnecessary_to_list_in_spreads #1927

merged 4 commits into from
Sep 20, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 20, 2022

Description

Adds these three sensible rules:

  • avoid_final_parameters
  • depend_on_referenced_package
  • unnecessary_to_list_in_spreads

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon requested a review from a team September 20, 2022 13:19
@spydon spydon merged commit deccb43 into main Sep 20, 2022
@spydon spydon deleted the spydon/add-more-lint-rules branch September 20, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st-pasha st-pasha st-pasha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @st-pasha