-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add CameraComponent to FlameGame #2740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
approved these changes
Sep 15, 2023
wolfenrain
approved these changes
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
luanpotter
reviewed
Sep 18, 2023
wolfenrain
reviewed
Sep 18, 2023
renancaraujo
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
CameraComponent
and aWorld
by default to the FlameGame.Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Migration instructions
We'll treat this as a breaking change since the
cameraComponent
name will clash with many of our users implementations, luckily it is very easy to migrate.If you have a game like this currently:
then you simply have to remove your own references to
cameraComponent
andworld
, so that it becomes like this:If you are using
CameraComponent.withFixedResolution
you can migrate to this: