Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Lottie bridge package #2157

Merged
merged 53 commits into from
Nov 22, 2022
Merged

feat: Lottie bridge package #2157

merged 53 commits into from
Nov 22, 2022

Conversation

tozu
Copy link
Contributor

@tozu tozu commented Nov 9, 2022 •
edited
Loading

Description

This PR adds support for Lottie animations to flame

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #1258

@tozu tozu marked this pull request as ready for review November 12, 2022 19:51
@tozu
Copy link
Contributor Author

tozu commented Nov 12, 2022

I am done with my implementation :)

the failing spell_checker task is due to fact that I mention:

  • "Bodymovin" - The adobe After effects export script/extension
  • "xaha.dev" - The maintainer of the 'lottie' package for Flutter

Is there any way how I can ease and please the spell_checker gently to allow these words? 🙂

erickzanardo
erickzanardo reviewed Nov 17, 2022
View reviewed changes
doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
packages/flame_lottie/LICENSE Outdated Show resolved Hide resolved
packages/flame_lottie/README.md Outdated Show resolved Hide resolved
packages/flame_lottie/lib/src/lottie_renderer.dart Outdated Show resolved Hide resolved
doc/bridge_packages/flame_lottie/flame_lottie.md Show resolved Hide resolved
tozu and others added 4 commits November 17, 2022 21:57
@tozu @erickzanardo
Update packages/flame_lottie/README.md
2a050aa 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@tozu @erickzanardo
Update packages/flame_lottie/LICENSE
92d8397 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@tozu @erickzanardo
Update doc/bridge_packages/flame_lottie/flame_lottie.md
b97ce25 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@tozu
make markdown linter happy
dbac3e4
spydon
spydon reviewed Nov 20, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some small comments

.github/.cspell/flame_lottie_dictionary.txt Outdated Show resolved Hide resolved
doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
packages/flame_lottie/lib/src/lottie_component.dart Outdated Show resolved Hide resolved
packages/flame_lottie/lib/src/lottie_component.dart Outdated Show resolved Hide resolved
packages/flame_lottie/pubspec.yaml Outdated Show resolved Hide resolved
packages/flame_lottie/pubspec.yaml Outdated Show resolved Hide resolved
packages/flame_lottie/test/flame_lottie_test.dart Outdated Show resolved Hide resolved
spydon
spydon approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just some very minor comments

doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_lottie/flame_lottie.md Outdated Show resolved Hide resolved
@spydon spydon mentioned this pull request Nov 22, 2022
Closed
7 tasks
tozu and others added 6 commits November 22, 2022 15:13
@tozu @spydon
Update examples/lib/stories/bridge_libraries/flame_lottie/lottie_anim…
aae97e7 
…ation_example.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@tozu @spydon
Update examples/pubspec.yaml
fd152b8 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@tozu @spydon
Update packages/flame_lottie/README.md
764a77b 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@tozu @spydon
Update packages/flame_lottie/README.md
e3ba0ac 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@tozu @spydon
Update packages/flame_lottie/example/README.md
bd582a7 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@tozu @spydon
Update packages/flame_lottie/example/pubspec.yaml
f369f92 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@spydon spydon enabled auto-merge (squash) November 22, 2022 21:32
@spydon spydon merged commit 3a73d14 into flame-engine:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted hacktoberfest-special
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lottie support
3 participants
@tozu @spydon @erickzanardo