Make loading of languages consistent across invocation types #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veracioux
requested review from
mmahmoudian
and removed request for
mmahmoudian
|
@mmahmoudian Please review it if you can. |
mmahmoudian
approved these changes
Sep 17, 2023
|
@veracioux It seems something didn't went well. I'm getting the following: ❯ flameshot gui
QLayout: Attempting to add QLayout "" to SidePanelWidget "", which already has a layout
[1] 275691 segmentation fault (core dumped) flameshot guiTriggering it from the tray icon works though |
any news about this crashing issue? |
|
@mohad12211 unfortunately not resolved yet. Please use clicking on the tray icon which works. This is very high priority and we will resolve it. |
This was referenced Oct 9, 2023
|
@mmahmoudian made a fix for the crash at #3370 :) |
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
Dec 22, 2023
…ot-org#3313) (cherry picked from commit 9557cd6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, languages are loaded only when invoking flameshot as a daemon, so localization doesn't work for the other invocation types. This fixes that.