Login logout #56

squishykid · 2018-10-11T04:51:40Z

Implementing some login and logout functionality.

The login info is not checked yet.

# Conflicts: # appService.Json # templates/appService.Json # templates/gulpfile.js # test/biz/test_manage_restaurant.py # web/friend.py # web/static/js/appService.Json # web/static/js/gulpfile.js # web/static/vendor/jquery-easing/jquery.easing.compatibility.js # web/static/vendor/jquery-easing/jquery.easing.js # web/static/vendor/jquery-easing/jquery.easing.min.js # web/templates/LICENSE # web/templates/blank.html # web/templates/gulpfile.js # web/templates/login.html

# Conflicts: # routes.py # test/biz/test_manage_restaurant.py # web/__init__.py # web/login.py # web/templates/404.html # web/templates/blank.html # web/templates/breadcrumb.html # web/templates/footer.html # web/templates/header.html # web/templates/index.html # web/templates/login.html # web/templates/nav.html # web/templates/register.html # web/templates/sidebar.html # web/templates/tables.html

chrisstime

I'm going to see if I can help out with this a little bit after work but ideally, we should be using this against the staff.py model to authenticate the user. Right?

chrisstime · 2018-10-15T20:39:31Z

web/templates/logoutModal.html

@@ -0,0 +1,18 @@
+<!-- Logout Modal-->
+<div class="modal fade" id="logoutModal" tabindex="-1" role="dialog" aria-labelledby="exampleModalLabel" aria-hidden="true">


Delete this file, it's not being used and looks like it's just doubled up.

chrisstime · 2018-10-15T20:50:17Z

web/login.py

+    return redirect(target)
+
+
+@LOGIN_BLUEPRINT.route("/", methods=['GET', 'POST'])


in my head this feels like this should be '/login' and '/' should redirect back to '/login' if user isn't logged in

it gets mounted in the router as /login/. it's just '/' relative to the blueprint. you can see in __init__.py how the blueprint is mounted under /login.

chrisstime · 2018-10-15T20:50:21Z

web/login.py

-    return render_template('login.html', page_title=page_title)
+    if request.method == 'POST':
+        session['username'] = request.form['email']
+        return redirect_back('index.index')


Why does it look to me like it's only posting the email for login..?

For now there's no actual authentication going on. This would be the work for the next pull request, to connect the staff table with this login code.

squishykid · 2018-10-15T22:30:31Z

Yep 👍

…

On Tue, 16 Oct 2018 at 07:57, Christine Vinaviles ***@***.***> wrote: ***@***.**** requested changes on this pull request. I'm going to see if I can help out with this a little bit after work but ideally, we should be using this against the staff.py model to authenticate the user. Right? ------------------------------ In web/templates/logoutModal.html <#56 (comment)>: > @@ -0,0 +1,18 @@ + +<div class="modal fade" id="logoutModal" tabindex="-1" role="dialog" aria-labelledby="exampleModalLabel" aria-hidden="true"> Delete this file, it's not being used and looks like it's just doubled up. ------------------------------ In web/login.py <#56 (comment)>: > +def get_redirect_target(): + for target in request.values.get('next'), request.referrer: + if not target: + continue + if is_safe_url(target): + return target + + +def redirect_back(endpoint, **values): + target = request.form['next'] + if not target or not is_safe_url(target): + target = url_for(endpoint, **values) + return redirect(target) + + ***@***.***_BLUEPRINT.route("/", methods=['GET', 'POST']) in my head this feels like this should be '/login' and '/' should redirect back to '/login' if user isn't logged in ------------------------------ In web/login.py <#56 (comment)>: > def index(): - page_title = 'Intelligent Restaurant System - Login' - return render_template('login.html', page_title=page_title) + if request.method == 'POST': + session['username'] = request.form['email'] + return redirect_back('index.index') Why does it look to me like it's only posting the email for login..? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#56 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACE7eEIHVkgXRhyd2WjZN-GDICj-HhXXks5ulPamgaJpZM4XWxxd> .

This reverts commit ec0f43a.

squishykid · 2018-10-20T02:55:46Z

So i'm just thinking about this a little more. I think that combining this with the staff.py class is out of scope of this pull request. We can make another pull request which implements that.

chrisstime

LGTM 👍

chrisstime · 2018-10-20T07:21:16Z

Happy to do staff.py in another PR

arosspope · 2018-10-20T08:06:15Z

What's the .env file for?

arosspope · 2018-10-20T08:07:58Z

Also, in this PR are you actually doing the authentication on the backend (i.e. hitting the db). Or was that going to be in another PR?

squishykid · 2018-10-20T08:19:46Z

Gonna double check the necessity of the env file. And there is a comment where we should implement the auth check - which will be another PR

squishykid · 2018-10-21T02:20:52Z

@arosspope @chrisstime this is ready to go. If you approve just do the squash&merge.

John Pham and others added 5 commits October 11, 2018 09:47

Template changes

101f56b

Pulling master changes into template_fixes

00525fc

routing and templating progress

94955bf

fuckuuuuu

7c8999f

beautiful

fe23e9f

squishykid requested review from inPhamous, chrisstime and nightsreach21 October 11, 2018 04:51

hmm

3bebf9b

squishykid requested review from a team as code owners October 11, 2018 04:54

squishykid added the work in progress Work in Progress label Oct 11, 2018

squishykid added 5 commits October 11, 2018 16:18

wew

3dc57b9

move

940dced

still messing up merges

c91b32d

chrisstime requested changes Oct 15, 2018

View reviewed changes

chrisstime and others added 5 commits October 18, 2018 10:41

push that thing

ec0f43a

Revert "push that thing"

be1aa65

This reverts commit ec0f43a.

still messing up merges

ee90bf1

redirecting all over the place

b89b88b

8/10 travis’s like this

1907c88

squishykid added 4 commits October 20, 2018 14:04

make the enter key work on login

7865ca8

cleanup and make correct button type

acc77c9

merges are my enemy

43c7e90

fix ur trash

e7b06f6

chrisstime previously approved these changes Oct 20, 2018

View reviewed changes

chrisstime added ready to merge ready to merge and removed work in progress Work in Progress labels Oct 20, 2018

cleaner

90812da

squishykid dismissed chrisstime’s stale review via 90812da October 21, 2018 02:18

arosspope approved these changes Oct 21, 2018

View reviewed changes

squishykid mentioned this pull request Oct 21, 2018

Report interface #30

Closed

3 tasks

arosspope merged commit 673cd1c into master Oct 21, 2018

arosspope deleted the login_logout branch October 21, 2018 02:29

squishykid mentioned this pull request Oct 21, 2018

The login button doesn’t work #63

Merged

squishykid self-assigned this Oct 21, 2018

squishykid added this to the End of Build 4 milestone Oct 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Login logout #56

Login logout #56

squishykid commented Oct 11, 2018

chrisstime left a comment

chrisstime Oct 15, 2018

chrisstime Oct 15, 2018

squishykid Oct 20, 2018 •

edited

Loading

chrisstime Oct 15, 2018

squishykid Oct 20, 2018

squishykid commented Oct 15, 2018 via email

squishykid commented Oct 20, 2018

chrisstime left a comment

chrisstime commented Oct 20, 2018

arosspope commented Oct 20, 2018 •

edited

Loading

arosspope commented Oct 20, 2018

squishykid commented Oct 20, 2018 •

edited

Loading

squishykid commented Oct 21, 2018

		@@ -0,0 +1,18 @@
		<!-- Logout Modal-->
		<div class="modal fade" id="logoutModal" tabindex="-1" role="dialog" aria-labelledby="exampleModalLabel" aria-hidden="true">

		return redirect(target)


		@LOGIN_BLUEPRINT.route("/", methods=['GET', 'POST'])

Login logout #56

Login logout #56

Conversation

squishykid commented Oct 11, 2018

chrisstime left a comment

Choose a reason for hiding this comment

chrisstime Oct 15, 2018

Choose a reason for hiding this comment

chrisstime Oct 15, 2018

Choose a reason for hiding this comment

squishykid Oct 20, 2018 • edited Loading

Choose a reason for hiding this comment

chrisstime Oct 15, 2018

Choose a reason for hiding this comment

squishykid Oct 20, 2018

Choose a reason for hiding this comment

squishykid commented Oct 15, 2018 via email

squishykid commented Oct 20, 2018

chrisstime left a comment

Choose a reason for hiding this comment

chrisstime commented Oct 20, 2018

arosspope commented Oct 20, 2018 • edited Loading

arosspope commented Oct 20, 2018

squishykid commented Oct 20, 2018 • edited Loading

squishykid commented Oct 21, 2018

squishykid Oct 20, 2018 •

edited

Loading

arosspope commented Oct 20, 2018 •

edited

Loading

squishykid commented Oct 20, 2018 •

edited

Loading