Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gencel #1

Merged
merged 24 commits into from
Jul 13, 2023
Merged

Gencel #1

merged 24 commits into from
Jul 13, 2023

Conversation

adityathebe
Copy link
Member

No description provided.

@adityathebe
gencel - initial commit
a8662f8
@adityathebe
Improved function overload name with correct suffix
3d882c3
@adityathebe
Can accept the whole pacakage as input.
de48888 
Instead of passing in a particular file path, now it's possible to
provide the package directory and gencel will generate on all the files
of the package
@adityathebe
Added more conversions and support for ignoring certain funcs with regex
0226dcc
@adityathebe
Copy link
Member Author

adityathebe commented Feb 1, 2023 •
edited
Loading

TODOs

  • handle multiple returns if possible (no native support)
  • handle slice returns
  • handle interface{} returns
  • put all the generated function into a slice so it can be easily imported as cel.EnvOption
  • handle collision of different functions with same func signature and name.
  • handle args of variadic functions (no native support)
  • handle package import automatically. Need to configure this manually

@adityathebe
Added more type conversions and a simple test
8ba5195
@adityathebe
WIP: Added support for multiple returns
959cd98
@adityathebe
Added gen files
7607c4d
@adityathebe
Added support for multiple returns
2bd03a1
@adityathebe
Handle package namespace
94b0163 
Example: Don't use just `IfAddrs` use the full name with pkg name also
`sockaddr.IfAddrs`
@adityathebe
Handle maps & arrays. Ignore _gen.go file as the source
09ef48d
@adityathebe
Ignore variadic functions for now
3cd3642
@adityathebe
Added tests for funcs that have multiple returns
665b97d
@adityathebe
Created a celEnv var that consists of all the generated cel function
47d6822
@adityathebe
Added namespaces to cel function to avoid collion for same function name
41cce98 
and type.

Example: the function `Match(pattern, name interface{}) (matched bool,
err error)` is defined for filepath, path. Now they're accessible as
path.Match & filepath.Match
@adityathebe
WIP: Support for variadic functions.
f1e75b4 
Renamed naming scheme for the cel funcs
@adityathebe
Added support for variadic functions ✔
328d4fb
@adityathebe
Added more test cases
5208ebc
@adityathebe
Handle imports for some files.
3117f91
@adityathebe adityathebe marked this pull request as ready for review February 3, 2023 09:47
moshloop
moshloop reviewed Jul 12, 2023
View reviewed changes
funcs/base64_gen.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Jul 12, 2023
View reviewed changes
funcs/cel_gen_exports.go Outdated Show resolved Hide resolved
@adityathebe
Copy link
Member Author

@moshloop had to disable some linters because I was getting linter errors for changes that I didn't make. Will create a new issue for that.

Also removed 3 github workflows that were build cmd/gomplate.go which doesn't exist anymore.

@moshloop moshloop merged commit ed70a73 into main Jul 13, 2023
@adityathebe adityathebe deleted the gencel branch July 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityathebe @moshloop