feat: support for conversion webhooks #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
added
the
publish/image/dev/amd64
github-actions
bot
removed
the
publish/image/dev/amd64
Closed
diafour
added
the
publish/image/dev/amd64
github-actions
bot
removed
the
publish/image/dev/amd64
nabokihms
reviewed
Feb 10, 2021
diafour
force-pushed
the
feat_conversion_binding
branch
from
afe982a
to
a63338f
Compare
diafour
added
the
publish/image/dev/amd64
github-actions
bot
removed
the
publish/image/dev/amd64
- add documentation - refactor validating webhook machinery - use kubernetes.io/tls type for webhook Secret - fix: initialize webhooks if there are bindings for them Co-authored-by: Maksim Nabokikh <32434187+nabokihms@users.noreply.github.com>
diafour
force-pushed
the
feat_conversion_binding
branch
from
6609968
to
3d378bf
Compare
|
Ready: reviewed and tested many times internally. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use hooks as conversion webhooks.
What this PR does / why we need it
See #41.
This PR adds a new binding
kubernetesCustomResourceConversion.Special notes for your reviewer
Does this PR introduce a user-facing change?