Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: get_required_circuit_models function #18

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

daquintero
Copy link
Contributor

Hi Floris,

Hope you are well! Thanks again for the great software.

This function is something that would be very handy as I'm integrating sax into my project. I think might be useful for other people when prototyping their models using sax circuits too.

Example usage:

from gdsfactory.components import mzi2x2_2x2
import sax
mzi2x2_netlist = mzi2x2_2x2().get_netlist(exclude_port_types="electrical")
sax.get_required_circuit_models(mzi2x2_netlist)

Returns:

['bend_euler', 'mmi2x2', 'straight']

What do you think?

@flaport
Copy link
Owner

flaport commented Jul 1, 2023

Thanks @daquintero , this is indeed a useful function!

I added your function to circuit.ipynb to keep the nbdev notebooks and library in sync. For the rest I kept everything the same :)

@flaport flaport merged commit acfe8f0 into flaport:main Jul 1, 2023
@flaport
Copy link
Owner

flaport commented Jul 1, 2023

Will be available in version 0.8.8.

@daquintero
Copy link
Contributor Author

Cheers Floris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants