Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation support for quote. #12

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Add translation support for quote. #12

merged 1 commit into from
Aug 23, 2021

Conversation

llaumgui
Copy link
Contributor

No description provided.

Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@askvortsov1 askvortsov1 merged commit 2d56d7f into flarum:master Aug 23, 2021
@dsevillamartin
Copy link
Member

This doesn't work because we don't have separate TextFormatter caches for different locales.

The configure method is only called when TextFormatter is recreating its cache. Therefore changing the language does not change the text.
Furthermore, this means that the "wrote" text will use the locale of whoever caused the TextFormatter cache to get build (e.g. random user visiting discussion after cache clear).

JpHv5zpdQa.mp4

davwheat added a commit that referenced this pull request Aug 28, 2021
davwheat added a commit that referenced this pull request Aug 28, 2021
@llaumgui
Copy link
Contributor Author

Is there any solution to build cache with locale in core ?

askvortsov1 pushed a commit that referenced this pull request Mar 11, 2022
askvortsov1 pushed a commit that referenced this pull request Mar 11, 2022
This reverts commit 8d79e45a48b6607860fdfe7c096873ea365f61ff.
askvortsov1 pushed a commit that referenced this pull request May 10, 2022
This reverts commit d6c01890a33293b604ac8a985e55c9b884a5aabf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants