Add accessibility attributes to loading spinner #2799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
After doing some research, it looks like we need a few a11y attributes on the loading spinner.
role="status"
seems a little weird at first (at least it did to me), but it's important. W3 describe a status message as:This role also sets an implicit
aria-live="polite"
, meaning screenreaders will know that the contents of this element may change in the future, and that they should notify the user of this element being added/removed/changed in real-time.We also add an accessible label to ensure that screen readers understand what the element is.
Screenshot
Confirmed