Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up JavaScript testing framework and write initial tests #4

Closed
tobyzerner opened this issue Dec 20, 2014 · 3 comments
Closed

Set up JavaScript testing framework and write initial tests #4

tobyzerner opened this issue Dec 20, 2014 · 3 comments

Comments

@tobyzerner
Copy link
Contributor

Now that we're using Mithril, we have complete freedom over what we use and how we use it.

A good starting point might be to copy whatever Mithril does itself.

@tobyzerner
Copy link
Contributor Author

OK I made a start on this too (at least I fixed JSHint errors) but I'm struggling to even get the first test running. All index-test.js is doing is calling visit('/') but it is still failing with the following unhelpful message:

    ---
        actual: >
            null
        message: >
            Error: Something went wrong
        Log: >
    ...

Can anyone lend a hand?

@tobyzerner
Copy link
Contributor Author

Sorted it out — it was because the API URL was wrong. Fixed in d13ef6f. Wrote some initial tests in bbf2c97. One is failing, waiting on kurko/ember-json-api#59

Ultimately we'll need to set up fixtures/synthetic AJAX responses rather than the calling a live API.

@tobyzerner
Copy link
Contributor Author

Closing in favour of flarum/issue-archive#424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant