Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop the need for a json-api-server fork #3986

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 10, 2024

Part of #3964

Changes proposed in this pull request:
With the recent changes to the json-api-server package made by Toby, it is easier to not rely on the package, though we still have to apply many custom changes in core itself, it is better than maintaining a fork and the custom changes are likely to decrease as the package becomes even more flexible in time.

Also the fork technicaly sill exists, but is 1:1 to the original package, until the original package is tagged with the latest changes Or we might always keep it manually 1:1 synced in case of any urgent changes.

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner May 10, 2024 13:17
@SychO9 SychO9 changed the title chore: drop the need for a json-api-server fork chore: drop the need for a json-api-server fork May 10, 2024
@SychO9 SychO9 marked this pull request as draft May 10, 2024 14:03
@SychO9 SychO9 force-pushed the sm/json-api-server-no-fork branch 2 times, most recently from 2d80977 to 269968e Compare May 10, 2024 19:29
@SychO9 SychO9 marked this pull request as ready for review May 11, 2024 11:43
@SychO9 SychO9 self-assigned this May 19, 2024
@luceos
Copy link
Member

luceos commented Jun 16, 2024

If we can drop our own fork in between I'd highly recommend doing that for now. We can see if that remains a valid strategy up to the beta builds of 2.0.

PS I have implemented this package on flarum.org now too and it seems to be very reliable and stable so far 👏

Base automatically changed from sm/json-api-server to 2.x June 21, 2024 08:36
@SychO9 SychO9 force-pushed the sm/json-api-server-no-fork branch from 5c613ca to 7504e31 Compare June 21, 2024 08:39
@SychO9 SychO9 merged commit 3dd2382 into 2.x Jun 21, 2024
21 of 47 checks passed
@SychO9 SychO9 deleted the sm/json-api-server-no-fork branch June 21, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants