Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request erasure controller #13

Merged
merged 16 commits into from
Mar 10, 2021
Merged

Request erasure controller #13

merged 16 commits into from
Mar 10, 2021

Conversation

imorland
Copy link
Member

No description provided.

askvortsov1
askvortsov1 requested changes Mar 10, 2021
View reviewed changes
extend.php Show resolved Hide resolved
resources/logo.svg Show resolved Hide resolved
src/Api/Controller/RequestDeletionController.php Outdated Show resolved Hide resolved
@askvortsov1
Copy link
Member

I think I might have accidentally left out my main comment: I propose that we stick with "erasure" for any names of the generic system, and deletion/anonymization only for the modes themselves. We can always change what it's called in the translations, but in the code, I think that consistency would help.

@imorland
Copy link
Member Author

Yeah, that makes sense. On it.

askvortsov1
askvortsov1 requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, since the frontend/backend split isn't that even here, I'd be happy to take care of the confirmation controller/blade template, as well as any cleanup that might be necessary to get this to work with the frontend side after review.

src/Api/Serializer/RequestErasureSerializer.php Outdated Show resolved Hide resolved
src/Models/ErasureRequest.php Show resolved Hide resolved
@imorland imorland marked this pull request as ready for review March 10, 2021 21:59
askvortsov1
askvortsov1 requested changes Mar 10, 2021
View reviewed changes
extend.php Outdated Show resolved Hide resolved
extend.php Outdated Show resolved Hide resolved
src/Api/Controller/RequestErasureController.php Outdated Show resolved Hide resolved
src/Api/Controller/RequestErasureController.php Show resolved Hide resolved
@imorland imorland changed the title WIP: request deletion controller/handler Request erasure controller Mar 10, 2021
askvortsov1
askvortsov1 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imorland imorland merged commit 1743fde into master Mar 10, 2021
@imorland imorland deleted the im/requestController branch March 10, 2021 22:44
@imorland imorland mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imorland @askvortsov1