Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update frappe-charts & use Serializing event #7

Closed
wants to merge 5 commits into from
Closed

[WIP] Update frappe-charts & use Serializing event #7

wants to merge 5 commits into from

Conversation

dsevillamartin
Copy link
Member

  • Update frappe-charts
  • Add CSS for comparison tooltip
  • Change Rendering event with Serializing event to add queries
    • currently no way to check if in admin page
    • polluting forum attributes instead of app.data
    • waiting for a better way

image

@tobyzerner
Copy link
Contributor

Pending flarum/framework#1602

@franzliedke
Copy link
Contributor

I pushed the DB changes directly to master, which I needed to test my extender changes.

Can we extract the separate parts of this PR (e.g. changing the package name) into separate PRs please?

@dsevillamartin dsevillamartin mentioned this pull request Oct 21, 2018
Merged
@dsevillamartin
Copy link
Member Author

@franzliedke As Toby committed the package name change, I just made another PR using the Extend\Frontend::document method.
See #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsevillamartin @tobyzerner @franzliedke