Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading bls comments #15

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

jtraglia
Copy link
Collaborator

@jtraglia jtraglia commented Jul 7, 2022

📝 Summary

  • Fix typo in contributing guidelines document.
  • Remove comments from pk/sig *FromBytes functions.
    • I believe that the SignatureFromBytes comment is misleading.
    • The public key and signature are big-endian, right? (see reference)
  • Use easier to read BLST types which are defined at the top of the file.
  • For sanity, add a signature verification test, stolen from Teku.

⛱ Motivation and Context

When looking over this file, the little-endian/big-endian difference seemed odd.

📚 References


✅ I have run these commands

  • make lint
  • make test
  • go mod tidy

@metachris
Copy link
Collaborator

thank you!

@metachris metachris merged commit cbdc1a5 into flashbots:main Jul 7, 2022
@jtraglia jtraglia deleted the remove-misleading-bls-comments branch July 7, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants