Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code health] refactor payload attrs checks in handleSubmitNewBlock #491

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

michaelneuder
Copy link
Collaborator

πŸ“ Summary

Pull the fee recipient check into an independent function. Follows up on #479.

β›± Motivation and Context

See M&C of #479.


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #491 (65e1417) into main (f729e37) will increase coverage by 0.54%.
The diff coverage is 96.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   30.67%   31.21%   +0.54%     
==========================================
  Files          24       24              
  Lines        4815     4821       +6     
==========================================
+ Hits         1477     1505      +28     
+ Misses       3140     3122      -18     
+ Partials      198      194       -4     
Flag Coverage Ξ”
unittests 31.21% <96.77%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Ξ”
services/api/service.go 36.16% <96.77%> (+1.34%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants