Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci run for develop branch, also fixes test badge #556

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

metachris
Copy link
Collaborator

📝 Summary

  • Missing change from main -> develop
  • Fixes 'failing tests' branch on develop README (currently it's just referring to whatever latest CI run, after this PR will refer to latest test on develop branch)

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

Codecov Report

Merging #556 (1868fc7) into develop (54eeaa2) will decrease coverage by 0.28%.
Report is 257 commits behind head on develop.
The diff coverage is 64.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #556      +/-   ##
===========================================
- Coverage    70.24%   69.96%   -0.28%     
===========================================
  Files            6        7       +1     
  Lines          541     1102     +561     
===========================================
+ Hits           380      771     +391     
- Misses         132      287     +155     
- Partials        29       44      +15     
Flag Coverage Δ
unittests 69.96% <64.23%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cli/main.go 0.00% <0.00%> (ø)
cli/types.go 0.00% <0.00%> (ø)
server/utils.go 74.50% <74.56%> (+6.93%) ⬆️
server/service.go 80.87% <78.70%> (+8.85%) ⬆️
server/mock_relay.go 92.18% <93.68%> (+9.33%) ⬆️
server/mock_types.go 100.00% <100.00%> (ø)
server/relay_entry.go 90.00% <100.00%> (+8.75%) ⬆️

... and 1 file with indirect coverage changes

@metachris metachris merged commit 0956355 into develop Aug 11, 2023
4 checks passed
@metachris metachris deleted the ci-fix branch August 11, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants