Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle scoring patch #76

Closed
thegostep opened this issue Jun 15, 2021 · 0 comments · Fixed by #77
Closed

bundle scoring patch #76

thegostep opened this issue Jun 15, 2021 · 0 comments · Fixed by #77
Assignees

Comments

@thegostep
Copy link

Change the way mev-geth performs bundle scoring to match the v0.2 spec.

The core issue is how the node handles transactions in the bundle that have a matching transaction in the txpool.

Currently, mev-geth considers two transactions with a matching nonce to be conflicting despite them having a different transaction hash and does not count the coinbase difference or the gasprice (related).

The proposed solution is to count the coinbase transfer of these transaction but not count the gas price.

jekkos pushed a commit to jekkos/mev-geth that referenced this issue Oct 31, 2021
Add Flashbots bundles to miner

Add Flashbots profit switching to miner

Add infra/CI and update README

Fix flashbots miners not correctly handling reorgs

Change flashbots bundle pricing formula to ignore gas fees

Discard bundles with reverting txs

Fixes flashbots#30

Change pricing formula to ignore gas from txs in the txpool

Fixes flashbots#39

Use object in eth_sendBundle params and add revertingTxHashes param

Fixes flashbots#40
Fixes flashbots#30

Add bundle merging with multiple workers

Update README.md

Add floor gas price for bundle inclusion in merged bundle

flashbots: count eth payments for txs whose nonce is in the mempool

Fixes flashbots#76

Add flashbots support for eip-1559

Add eth_callBundle rpc method

Add syncmode archive to geth cluster

Add more fields to simulation

Create new evm per message in eth_callBundle

This fixes an error with tx.origin being incorrect

Add coinbase arg to eth_callBundle

Change eth_callBundle to use more accurate ApplyTransaction

Also fork ApplyTransaction to add in the result, so we can see revert
reasons and return values

Fix tx parsing in eth_callBundle

Update eth_callBundle to accept an object

Fix bug in CallBundle not preparing state

This leads to bad gas used calculations

Add more fields to txs in callBundle

Add fromAddress and toAddress in callBundle

Fix possible nil tx.To() in callBundle

flashbots: Add gasLimit and difficulty as options for callBundle

Fix ApplyTransactionWithResult needing header.BaseFee

Update healthcheck and remove snapshot

Fixes for eth_callBundle rebase onto v1.10.5

Fix make command for infra build

flashbots: Add baseFee to callBundle

Revert to master readme

Rebase on master 1.10.9

Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants