Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx: Add UP metrics #608

Merged
merged 2 commits into from
Aug 18, 2023
Merged

nginx: Add UP metrics #608

merged 2 commits into from
Aug 18, 2023

Conversation

lesteryou
Copy link
Contributor

nginx: Add UP metrics

@kongfei605
Copy link
Collaborator

后面我们插件都添加个前缀 + "_up"的指标

@kongfei605
Copy link
Collaborator

Than you @lesteryou

@kongfei605 kongfei605 merged commit 5f13d4d into flashcatcloud:main Aug 18, 2023
@lesteryou
Copy link
Contributor Author

image
@kongfei605
func (l *SampleList) PushSamples(prefix string, fields map[string]interface{}, labels ...map[string]string)
在这个function中传入的fields,不应该再添加 “nginx_”前缀了,第一个参数就是prefix,否则会出现 “nginx_nginx_up”的指标

@kongfei605
Copy link
Collaborator

image @kongfei605 func (l *SampleList) PushSamples(prefix string, fields map[string]interface{}, labels ...map[string]string) 在这个function中传入的fields,不应该再添加 “nginx_”前缀了,第一个参数就是prefix,否则会出现 “nginx_nginx_up”的指标

最新的PR已Merge,再次感谢热心的伙伴 @lesteryou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants