fits the quantile value metric for the distribution class metric in googlecloud #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e googlecloud.default is p50/75/90/95/99/999/mean
kongfei605
reviewed
Aug 30, 2023
| @@ -7,10 +7,10 @@ import ( | |||
| "time" | |||
|
|
|||
| "cloud.google.com/go/monitoring/apiv3/v2/monitoringpb" | |||
| "flashcat.cloud/categraf/inputs/googlecloud/internal" | |||
There was a problem hiding this comment.
import 顺序一般是系统库 、第三方库 、自己的库
There was a problem hiding this comment.
got it. 这块应该是idea没format好
kongfei605
reviewed
Aug 30, 2023
inputs/googlecloud/connection.go
Outdated
| // append mean quantile to slice | ||
| for i, qt := range append( | ||
| quantile.GetQuantiles(), | ||
| point.GetValue().GetDistributionValue().Mean, |
There was a problem hiding this comment.
GetMean() 和 Mean 我看了下都可以，但是为了保持一致性，我这里后续会统一调整为方法调用。晚上我统一再调整下代码
|
@kongfei605 import 顺序已经调整；Mean 已经调整为 GetMean()。 |
|
Thank you @resurgence72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 googlecloud 中的 distribution 类指标适配分位值指标；当前看只记录了 xxx_sum 的 count 值。
PS: 当前开发环境暂无gcp账号，需要 categraf maintainers 验证 + review下。