Skip to content

*: Replace kinvolk github org with flatcar-linux #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Dec 21, 2021

Stop relying on github redirects, they are a mixed blessing and using
them broke emerge-gitclone inside dev-container in silent way. The
script could not find a desired revision of portage-stable or
coreos-overlay, because it tried to pull from kinvolk instead of
flatcar-linux github org. The redirects seem to hinder fetching a
specific commit, so the script pulled something else (HEAD or main?).

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

CI: http://localhost:9091/job/os/job/manifest/4445/cldsv/

Fixes flatcar/Flatcar#577

Stop relying on github redirects, they are a mixed blessing and using
them broke emerge-gitclone inside dev-container in silent way. The
script could not find a desired revision of portage-stable or
coreos-overlay, because it tried to pull from kinvolk instead of
flatcar-linux github org. The redirects seem to hinder fetching a
specific commit, so the script pulled something else (HEAD or main?).
@krnowak krnowak marked this pull request as ready for review December 22, 2021 15:57
@krnowak krnowak requested a review from a team December 22, 2021 15:57
@krnowak
Copy link
Member Author

krnowak commented Dec 22, 2021

CI passed.

Copy link
Member

@t-lo t-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @krnowak!

@krnowak krnowak merged commit edcc436 into main Dec 22, 2021
@krnowak krnowak deleted the krnowak/replace-kinvolk branch December 22, 2021 16:35
@krnowak
Copy link
Member Author

krnowak commented Dec 22, 2021

Cherry-picked to flatcar 3033, 3066 and 3087. LTS didn't need the fix.

@krnowak krnowak removed the lts label Dec 22, 2021
t-lo pushed a commit that referenced this pull request Apr 17, 2023
app-portage/portage-utils: update to 0.90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emerge-gitclone: always checks out HEAD because of 'kinvolk' git clone url vs. 'flatcar-linux' in release.xml
2 participants