Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition: fixes hyperv oem support #92

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ader1990
Copy link
Contributor

@ader1990 ader1990 commented Mar 26, 2024

Upstream Hyper-V ignition support requires hv_utils module.

See: coreos/ignition@d304850

Ignition initrd is failing here: https://github.com/coreos/ignition/blob/v2.18.0/internal/providers/hyperv/kvp.go#L50.
Flatcar kernel is built with hv_utils kernel module, but the module is not present in initrd /lib/modules because it has not been installed.

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@ader1990
Copy link
Contributor Author

Found out that PR flatcar/scripts#1680 introduced coreos/ignition@d304850, which means the Hyper-V VHD is broken due to not adding this change to the bootengine.

@ader1990
Copy link
Contributor Author

Boot partition used space: 62620 KB, which is a normal increase, as the hv_utils.ko.xz size is 20K.

Upstream Hyper-V ignition support requires now the `hv_utils` module.
See: coreos/ignition@d304850

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@ader1990 ader1990 changed the title ignition: add hyperv oem support ignition: fixes hyperv oem support Mar 26, 2024
ader1990 added a commit to flatcar/scripts that referenced this pull request Mar 26, 2024
Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@ader1990
Copy link
Contributor Author

Tested locally with this patch and Hyper-V vhdx is booting correctly now (ignition is running correctly during initrd stage now).

@ader1990 ader1990 merged commit 224a172 into flatcar:flatcar-master Mar 26, 2024
ader1990 added a commit to flatcar/scripts that referenced this pull request Mar 26, 2024
Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to flatcar/scripts that referenced this pull request Mar 26, 2024
Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to flatcar/scripts that referenced this pull request Mar 27, 2024
Add support for Gen 2 Hyper-V VMs.

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to flatcar/scripts that referenced this pull request Mar 27, 2024
Add support for Gen 2 Hyper-V VMs.

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to flatcar/scripts that referenced this pull request Mar 27, 2024
Add support for Gen 2 Hyper-V VMs.

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to ader1990/scripts that referenced this pull request Mar 27, 2024
Add support for Gen 2 Hyper-V VMs.

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to ader1990/scripts that referenced this pull request Mar 29, 2024
Add support for Gen 2 Hyper-V VMs.

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to flatcar/scripts that referenced this pull request Apr 9, 2024
Add support for Gen 2 Hyper-V VMs.

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to flatcar/scripts that referenced this pull request Apr 9, 2024
Add support for Gen 2 Hyper-V VMs.

`./image_to_vm` tool has now a new supported format: `hyperv_vhdx`,
that produces .vhdx dynamic disks.

How to use:

```bash
 ./image_to_vm.sh --from ../build/images/amd64-usr/developer-latest/ --format hyperv_vhdx
```

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants