ignition: fixes hyperv oem support #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepio
approved these changes
Mar 26, 2024
|
Found out that PR flatcar/scripts#1680 introduced coreos/ignition@d304850, which means the Hyper-V VHD is broken due to not adding this change to the bootengine. |
|
Boot partition used space: |
Upstream Hyper-V ignition support requires now the `hv_utils` module. See: coreos/ignition@d304850 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
force-pushed
the
ader1990/hyper-v-support
branch
from
5007779
to
364adc2
Compare
ader1990
changed the title
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Mar 26, 2024
Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
|
Tested locally with this patch and Hyper-V vhdx is booting correctly now (ignition is running correctly during initrd stage now). |
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Mar 26, 2024
Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Mar 26, 2024
Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Mar 27, 2024
Add support for Gen 2 Hyper-V VMs. See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Mar 27, 2024
Add support for Gen 2 Hyper-V VMs. See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Mar 27, 2024
Add support for Gen 2 Hyper-V VMs. See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to ader1990/scripts
that referenced
this pull request
Mar 27, 2024
Add support for Gen 2 Hyper-V VMs. See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to ader1990/scripts
that referenced
this pull request
Mar 29, 2024
Add support for Gen 2 Hyper-V VMs. See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Apr 9, 2024
Add support for Gen 2 Hyper-V VMs. See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Apr 9, 2024
Add support for Gen 2 Hyper-V VMs. `./image_to_vm` tool has now a new supported format: `hyperv_vhdx`, that produces .vhdx dynamic disks. How to use: ```bash ./image_to_vm.sh --from ../build/images/amd64-usr/developer-latest/ --format hyperv_vhdx ``` See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Hyper-V ignition support requires
hv_utilsmodule.See: coreos/ignition@d304850
Ignition initrd is failing here: https://github.com/coreos/ignition/blob/v2.18.0/internal/providers/hyperv/kvp.go#L50.
Flatcar kernel is built with hv_utils kernel module, but the module is not present in initrd /lib/modules because it has not been installed.
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.