ensure-sysext: drop daemon-reload command #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
force-pushed
the
tormath1/sysext
branch
from
f9b63b9
to
81e3f7c
Compare
4 tasks
pothos
reviewed
Apr 24, 2023
systemd/system/ensure-sysext.service
Outdated
| @@ -11,7 +11,6 @@ ConditionDirectoryNotEmpty=|/usr/lib/extensions | |||
| [Service] | |||
| Type=oneshot | |||
| RemainAfterExit=yes | |||
| ExecStart=/usr/bin/systemctl daemon-reload | |||
| ExecStart=/usr/bin/systemctl restart --no-block sockets.target timers.target multi-user.target | |||
There was a problem hiding this comment.
Most things are also converted to use Upholds=, I think we should also drop this line here (and call it out in the changelog).
There was a problem hiding this comment.
If we drop this line too we can actually drop this unit.
|
I think we can use this now |
systemd-sysext will perform a daemon-reload for each merge / unmerge / refresh action. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/sysext
branch
from
6c15b3f
to
db06907
Compare
3 tasks
Oh yes - 1y later! Rebased and kicked off a CI, let's see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-sysext will perform a daemon-reload for each merge / unmerge / refresh action.
Related to: flatcar/Flatcar#984