-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ssh configs to coreos-base/misc-files package in our overlay #98
Conversation
@@ -1,17 +0,0 @@ | |||
# Use most defaults for sshd configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of re-adding this through the misc package, could we change the install directive to put it into /etc
(but I guess it's a taste question of either having files in a repo like here or under the files/
ebuild subfolder).
I think we also need one of those compat symlinks for /usr/share/ssh/ssh(d)_config
to point to the file under /usr/share/flatcar/etc
or something like that. The old symlink for existing installations could stick around and thus require that target to be present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of re-adding this through the misc package, could we change the install directive to put it into
/etc
(but I guess it's a taste question of either having files in a repo like here or under thefiles/
ebuild subfolder).
Yeah, my opinion was that this repo is no place for ssh configs, Thus the move.
I think we also need one of those compat symlinks for
/usr/share/ssh/ssh(d)_config
to point to the file under/usr/share/flatcar/etc
or something like that. The old symlink for existing installations could stick around and thus require that target to be present.
These are done by coreos-base/misc-files in the scripts PR.
95bf5c2
to
03f851a
Compare
03f851a
to
76600d3
Compare
This will be pulled into image as a part of flatcar/scripts#945. |
The ssh and sshd configuration in Gentoo has been changed from a single file thing to a single file config including configuration snippets in /etc/ssh{,d}_config.d/ directory. We will ride on this change and turn our ssh configs into such snippets. But these will be installed by a different package directly into /etc/ssh directory. This makes the tmpfiles config file creating symlinks for ssh configs unnecessary, so drop it too.
76600d3
to
a7f121f
Compare
The ssh and sshd configuration in Gentoo has been changed from a single file thing to a single file config including configuration snippets in /etc/ssh{,d}_config.d/ directory. We will ride on this change and turn our ssh configs into such snippets. But these will be installed by a different package directly into /etc/ssh directory. This makes the tmpfiles config file creating symlinks for ssh configs unnecessary, so drop it too.