Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: Shorten TPM test name to keep the socket path under the limit #525

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

pothos
Copy link
Member

@pothos pothos commented Apr 15, 2024

The TPM directory is created under the _kola_temp folder for the VM. In total the path used for the swtpm socket was above the 108 char limit for some tests.
Shorten the affected test names to keep the socket path under the limit.

How to use

Rerun Jenkins tests with this

Testing done

Tests passed for qemu on amd64 and qemu_uefi on arm64

@pothos
Copy link
Member Author

pothos commented Apr 15, 2024

For Beta arm64 I saw even the basic clevis root/nonroot test failing but there is no socket-related error message:
http://jenkins.infra.kinvolk.io:8080/job/container/job/test/21731/consoleFull I don't know yet what else might have changed. Originally the socket was under a tempdir in /tmp. Since this new longer path works on amd64 it might be something else, e.g., a forgotten backport from main to the last Alpha branch.

@pothos
Copy link
Member Author

pothos commented Apr 15, 2024

For Beta arm64 I saw even the basic clevis root/nonroot test failing but there is no socket-related error message:
http://jenkins.infra.kinvolk.io:8080/job/container/job/test/21731/consoleFull I don't know yet what else might have changed. Originally the socket was under a tempdir in /tmp. Since this new longer path works on amd64 it might be something else, e.g., a forgotten backport from main to the last Alpha branch.

Found it, the arm64 kernel module change was missing: flatcar/scripts#1755

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could even drop the cl ... but it should be enough now. Thanks!

The TPM directory is created under the _kola_temp folder for the VM. In
total the path used for the swtpm socket was above the 108 char limit
for some tests.
Shorten the affected test names to keep the socket path under the limit.
@pothos pothos merged commit 9af1d02 into flatcar-master Apr 15, 2024
3 checks passed
@pothos pothos deleted the kai/tpmsocklen branch April 15, 2024 10:05
@jepio
Copy link
Member

jepio commented Apr 16, 2024

@pothos @tormath1 the swtpm process can be changed to run with working directory set to the tpm folder :)

@pothos
Copy link
Member Author

pothos commented Apr 16, 2024

@pothos @tormath1 the swtpm process can be changed to run with working directory set to the tpm folder :)

Right, or even the folder above the tpm folder would be equally good, initially I considered reverting to /tmp mktmpdir stuff but your idea is better :D It's strange that this kernel limitation is for relative paths and not for the full path.

@pothos
Copy link
Member Author

pothos commented Apr 16, 2024

Turned out to be a bit more complicated because qemu also needs to run with that working dir to have a short socket path argument: #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants