Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to nvidia.service to allow ordering on the subsequent services #1047

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

shsamkit
Copy link
Contributor

@shsamkit shsamkit commented Aug 3, 2023

Changes to nvidia.service to allow ordering on the subsequent services

When changed to oneshot, the subsequent services wiill actually wait for the nvidia.service to finish, i.e. wait for drivers to be installed. The subsequent services can be configured to wait for nvidia.service. This needs to be coupled with
RemainAfterExit=yes to ensure it doesn't get kicked-off automatically again.
Solves : flatcar/Flatcar#1136

How to use

Testing done

  • Setup a new service that is After and Wants containerd.target - Make sure it stays disabled until containerd.target & nvidia.service are completed successfully - tested with a drop-in unit

Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing the PR

@sayanchowdhury
Copy link
Member

Running the CI http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/2273/cldsv/

I will post the results after it completes.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/5769124647

@sayanchowdhury
Copy link
Member

sayanchowdhury commented Aug 4, 2023

CI passed, @shsamkit should we move this PR to ready to review?

Also, could you squash the commits into one, and add required description into the commit description.

@shsamkit
Copy link
Contributor Author

shsamkit commented Aug 4, 2023

@sayanchowdhury, sure will do that

@shsamkit shsamkit changed the title [WIP] Changes to nvidia.service to allow ordering on the subsequent services Changes to nvidia.service to allow ordering on the subsequent services Aug 4, 2023
@shsamkit shsamkit marked this pull request as ready for review August 4, 2023 19:36
@shsamkit
Copy link
Contributor Author

shsamkit commented Aug 4, 2023

Is the commit message alright @sayanchowdhury ?

@sayanchowdhury
Copy link
Member

Thanks the message looks good, Could also please create a changelog entry?

You would need to create a file eg 2023-08-05-change-nvidia-oneshot.md in the $SCRIPTS_ROOT/changelog/changes. Here a few examples to refer:

@shsamkit
Copy link
Contributor Author

shsamkit commented Aug 8, 2023

on it

When changed to oneshot, the subsequent services wiill actually wait for the nvidia.service to finish, i.e. wait for drivers to be installed. The subsequent services can be configured to wait for nvidia.service. This needs to be coupled with
RemainAfterExit=yes to ensure it doesn't get kicked-off automatically again.
Solves : flatcar/Flatcar#1136
@shsamkit
Copy link
Contributor Author

shsamkit commented Aug 9, 2023

@sayanchowdhury thanks for your help. I think this is ready to review/merge now.

Copy link
Member

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants