Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify filesystem-manipulating code in wrapper #992

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

gasinvein
Copy link
Member

shutil.copytree() from the standard library has everything we need, namely the ability to use custom path exclude logic, so we don't really need to reinvent the wheel.

@flathubbot
Copy link
Contributor

Started test build 3005

@nanonyme
Copy link
Collaborator

Have you locally tested it? You can first bypass helper to create incorrect data to force migration

@flathubbot
Copy link
Contributor

Build 3005 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/115442/com.valvesoftware.Steam.flatpakref

@gasinvein
Copy link
Member Author

gasinvein commented Oct 22, 2022

Have you locally tested it?

Yeah, superficially. The idea is to trust shutil.copytree to do the right thing. The only custom code now is the one filtering ignored subpaths.

You can first bypass helper to create incorrect data to force migration

That's what I did.

@nanonyme nanonyme merged commit aaeec92 into flathub:beta Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants