Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.rustdesk.RustDesk #5233

Closed
wants to merge 13 commits into from
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
repo
builddir
.flatpak-builder
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "shared-modules"]
path = shared-modules
url = https://github.com/flathub/shared-modules.git
116 changes: 116 additions & 0 deletions com.rustdesk.RustDesk.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
{
"id": "com.rustdesk.RustDesk",
"runtime": "org.freedesktop.Platform",
"runtime-version": "23.08",
"sdk": "org.freedesktop.Sdk",
"command": "rustdesk",
"finish-args": [
"--share=ipc",
"--socket=wayland",
"--socket=x11",
bbhtt marked this conversation as resolved.
Show resolved Hide resolved
"--share=network",
"--filesystem=home",
"--device=dri",
"--socket=pulseaudio",
"--talk-name=org.freedesktop.Flatpak"
],
"modules": [
"shared-modules/libappindicator/libappindicator-gtk3-12.10.json",
{
"name": "xdotool",
"buildsystem": "simple",
"build-commands": [
"make -j4 && PREFIX=./build make install",
"cp -r ./build/* /app/"
],
"sources": [
{
"type": "archive",
"url": "https://github.com/jordansissel/xdotool/releases/download/v3.20211022.1/xdotool-3.20211022.1.tar.gz",
"sha256": "96f0facfde6d78eacad35b91b0f46fecd0b35e474c03e00e30da3fdd345f9ada"
}
]
},
{
"name": "pam",
"buildsystem": "simple",
"build-commands": [
"./configure --disable-selinux --prefix=/app && make -j4 install"
],
"sources": [
{
"type": "archive",
"url": "https://github.com/linux-pam/linux-pam/releases/download/v1.3.1/Linux-PAM-1.3.1.tar.xz",
"sha256": "eff47a4ecd833fbf18de9686632a70ee8d0794b79aecb217ebd0ce11db4cd0db"
}
]
},
{
"name": "libarchive",
"buildsystem": "autotools",
"config-opts": [
"--disable-static"
],
"sources": [
{
"type": "archive",
"url": "https://github.com/libarchive/libarchive/releases/download/v3.5.1/libarchive-3.5.1.tar.gz",
"sha256": "9015d109ec00bb9ae1a384b172bf2fc1dff41e2c66e5a9eeddf933af9db37f5a"
}
]
},
{
"name": "rustdesk",
"buildsystem": "simple",
"build-commands": [
"bsdtar -zxvf rustdesk.deb",
"tar -xvf ./data.tar.xz",
"rm -rf usr/share/icons/hicolor/scalable/",
"cp -r usr/* /app/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the metainfo info being installed. You removed it from here, but it is not present in the .deb

Copy link
Author

@rustdesk rustdesk May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know not installed? I did see installed from log of flatpak-build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it be installed when it is not in the deb and nowhere in the manifest as a source?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is closed, you do not need to review any more. #5233 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you seem to know better, neither of the line above show the appstream file. So yeah the appstream file isn't installed.

"mkdir -p /app/bin && ln -s /app/lib/rustdesk/rustdesk /app/bin/rustdesk"
],
"sources": [
{
"type": "file",
"only-arches": [
"aarch64"
],
"url": "https://github.com/rustdesk/rustdesk/releases/download/1.2.4/rustdesk-1.2.4-aarch64.deb",
"sha256": "4f8be7199a1e8acf0799ce8cea6af08bcf2d6f073a3a098809ac842e3a87d1e8",
"dest-filename": "rustdesk.deb",
"x-checker-data": {
"type": "anitya",
"project-id": "309593",
"url-template": "https://github.com/rustdesk/rustdesk/releases/download/$version/rustdesk-$version-aarch64.deb"
}
},
{
"type": "file",
"only-arches": [
"x86_64"
],
"url": "https://github.com/rustdesk/rustdesk/releases/download/1.2.4/rustdesk-1.2.4-x86_64.deb",
"sha256": "43c2f43ad7a8a173fa51093944243f04f003f675e74812644780eee1468b3f9b",
"dest-filename": "rustdesk.deb",
"x-checker-data": {
"type": "anitya",
"project-id": "309593",
"url-template": "https://github.com/rustdesk/rustdesk/releases/download/$version/rustdesk-$version-x86_64.deb"
}
}
]
}
],
"rename-desktop-file": "rustdesk.desktop",
"rename-icon": "rustdesk",
rustdesk marked this conversation as resolved.
Show resolved Hide resolved
"cleanup": [
rustdesk marked this conversation as resolved.
Show resolved Hide resolved
"/include",
"/lib/pkgconfig",
"/share/gtk-doc",
"/share/man",
"/lib/*.la",
rustdesk marked this conversation as resolved.
Show resolved Hide resolved
"/share/gtk-doc",
"/bin/bsd*",
"/libs/libarchive*"
]
}
39 changes: 39 additions & 0 deletions com.rustdesk.RustDesk.metainfo.xml
rustdesk marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright 2023 Bernd Schoolmann -->
<component type="desktop">
<id>com.rustdesk.RustDesk</id>
<launchable type="desktop-id">com.rustdesk.RustDesk.desktop</launchable>
<metadata_license>CC0-1.0</metadata_license>
<project_license>AGPL-3.0-only</project_license>
<name>RustDesk</name>
<summary>An open-source remote desktop, and alternative to TeamViewer</summary>
<description>
<p>
RustDesk is a full-featured open source remote control alternative for self-hosting and security with minimal configuration.
</p>
<ul>
<li> Works on Windows, macOS, Linux, iOS, Android, Web. </li>
<li> Supports VP8 / VP9 / AV1 software codecs, and H264 / H265 hardware codecs. </li>
<li> Own your data, easily set up self-hosting solution on your infrastructure. </li>
<li> P2P connection with end-to-end encryption based on NaCl. </li>
<li> No administrative privileges or installation needed for Windows, elevate priviledge locally or from remote on demand. </li>
<li> We like to keep things simple and will strive to make simpler where possible. </li>
</ul>
<p>
For self-hosting setup instructions please go to our home page.
</p>
</description>
<categories>
<category>Utility</category>
</categories>
<screenshots>
<screenshot type="default">
<image>https://user-images.githubusercontent.com/71636191/171661982-430285f0-2e12-4b1d-9957-4a58e375304d.png</image>
</screenshot>
</screenshots>
<url type="homepage">https://rustdesk.com</url>
<releases>
<release version="v1.2.4" date="2024-05-11"/>
</releases>
<content_rating type="oars-1.1"/>
</component>
1 change: 1 addition & 0 deletions shared-modules
Submodule shared-modules added at 782d3c