Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for <em> tags in release notes #131

Closed
jarek-foksa opened this issue Apr 12, 2022 · 10 comments
Closed

Missing support for <em> tags in release notes #131

jarek-foksa opened this issue Apr 12, 2022 · 10 comments

Comments

@jarek-foksa
Copy link

According to the official Freedesktop documentation metainfo files can contain <description> tags with emphasis (<em>) tags inside them. However, this does not seem to be supported by the beta Flathub website. For example, the following XML code:

<releases>
  <release version="3.82.0" date="2022-04-09">
    <description>
      <ul>
        <li><em>Added:</em> Adwaita theme</li>
        <li><em>Added:</em> Adwaita Dark theme</li>
        <li><em>Fixed:</em> Keyboard shortcuts are fired while filling forms</li>
      </ul>
    </description>
  </release>
</releases>

... is rendered as follows:

Screen Shot 2022-04-12 at 09 51 09

@razzeee razzeee transferred this issue from flathub-infra/frontend Apr 12, 2022
@JakobDev
Copy link
Contributor

This is currently a Bug in Flathub Builder. The <em> tag gets removed from AppStream, so tehres nothing that Flathub can show. Should be fixed with flatpak/flatpak-builder#418.

@razzeee
Copy link
Member

razzeee commented Jan 26, 2023

Hrm, but https://beta.flathub.org/apps/details/codes.merritt.Nyrna has an em tag somehow.

@YeldhamDev
Copy link

Currently, the <em> tag is just shown in raw form. You can see it happening here in the changelog:
https://flathub.org/apps/page.codeberg.yeldham.Librerama

@hfiguiere
Copy link

hfiguiere commented Jun 5, 2023

@razzeee
Copy link
Member

razzeee commented Jun 5, 2023

Seems to work now, but needs the app to be rebuild

@razzeee
Copy link
Member

razzeee commented Jun 6, 2023

All apps listed here seem to be fixed as far as I can tell.

@razzeee razzeee closed this as completed Jun 6, 2023
@YeldhamDev
Copy link

@razzeee The changelog on mine still shows the tags, will rebuilding it fix it now?

@razzeee
Copy link
Member

razzeee commented Jun 6, 2023

I would think so, but I think technically it's not exactly supported in releases. So it's probably fine on the website, but broken in gnome software.

@razzeee razzeee reopened this Nov 26, 2023
cassidyjames added a commit to cassidyjames/org.godotengine.Godot that referenced this issue Jan 19, 2024
I previously missed that [`<em>` is not yet supported by Flathub](flathub-infra/website#131) even though it's in [the AppStream spec](https://freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-description). For now, we shouldn't use it because it looks ugly on Flathub.
@razzeee
Copy link
Member

razzeee commented Feb 17, 2024

This should start working after rebuilding

@razzeee razzeee closed this as completed Feb 18, 2024
Calinou pushed a commit to flathub/org.godotengine.Godot that referenced this issue Mar 5, 2024
* Metainfo: Better align to other store listings

This PR accomplishes a few things:
- Adapts the name and description to better match that used on [Itch](https://godotengine.itch.io/godot), [Steam](https://store.steampowered.com/app/404790/Godot_Engine/), and [Epic Games Store](https://store.epicgames.com/en-US/p/godot-engine) for consistency
- Better follow the [Flathub quality guidelines](https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/quality-guidelines) with the summary

* Metainfo: Remove unsupported `<em>` tag

I previously missed that [`<em>` is not yet supported by Flathub](flathub-infra/website#131) even though it's in [the AppStream spec](https://freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-description). For now, we shouldn't use it because it looks ugly on Flathub.

* Metainfo: Correct SFC → Godot Foundation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@hfiguiere @jarek-foksa @razzeee @JakobDev @YeldhamDev and others