Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-bind seems to be lost/broken since the last refactor #12

Closed
mwawrusch opened this issue Nov 17, 2011 · 8 comments
Closed

data-bind seems to be lost/broken since the last refactor #12

mwawrusch opened this issue Nov 17, 2011 · 8 comments

Comments

@mwawrusch
Copy link
Contributor

Yeah, not so good.

@jfhbrook
Copy link
Contributor

Uh-oh! Thanks for the heads-up.

@mwawrusch
Copy link
Contributor Author

Hi Joshua, Mmalecki knows about it too, just talked to him over at the chat. Tests need to be adapted to the new syntax as well. It would be really great if we could talk about the data-bind-xxx syntax, that would solve so many problems. I am over at #nodejitsu as martin_sunset if you have time

@mwawrusch
Copy link
Contributor Author

Tried to refactor the tests to at least get that one working, but get an error at line 18

https://gist.github.com/1374702

@mmalecki
Copy link
Contributor

I don't think that tests should be adapted, I'd say that plates should be fixed

@mwawrusch
Copy link
Contributor Author

The call signature of plates has been completely changed. Not sure if it is a better one yet, but it is different, so either the part invoking plates in the tests need to be changed or the call signature of plates and the readme.

Whatever will be done please do it fast. I am running this in beta/production and this whole slashfactory has cost me a couple of hours already today that I just don't have.

As I said here or on another issue: Split templating and parsing into 2 separate classes, that way appinsanity and I can fix bugs and add a couple of features and we will have a working and usable template library.

@heapwolf
Copy link
Contributor

yo. its orders of magnitude better. this project was rushed out, now its better. and data-bind was removed on purpose.

@heapwolf
Copy link
Contributor

btw, technically, you could still do data-bind if you really want, but its really just an over abstraction and doesn't need to exist for the 80/20.

  var html = '<div id="bar" data-bind="foo"></div>';
  var data = { "bar": "Hello, World" };

  var options = { "bar": "data-bind" };

  var output = Plates.bind(html, data, options);

@heapwolf
Copy link
Contributor

@mwawrusch if the update broke your software, just pull from earlier commits. this is not 1.0 software, its not stable, when 1.0 rolls out, we'll be out of dev and more considerate about impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants