Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IE7/IE8 #54

Closed
tauren opened this issue Apr 2, 2012 · 2 comments
Closed

Support for IE7/IE8 #54

tauren opened this issue Apr 2, 2012 · 2 comments

Comments

@tauren
Copy link
Contributor

tauren commented Apr 2, 2012

I just attempted to run my app that uses Plates in IE8 and it blew up. I noticed pull request #53 makes plates more compatible with ES3, so I thought Plates might work in IE8.

Is there already support for IE7/IE8? If not, is it something that is planned? If there is support, what shims are required to make it work? My application needs to support IE7+, and I'm trying to determine how much effort will be involved to use Plates.

I'm already using this style of accessing reserved words:

this.mapping['class']('check').use('done').as('checked');

Instead of this:

this.mapping.class.('check').use('done').as('checked');
@3rd-Eden
Copy link
Member

3rd-Eden commented Aug 7, 2012

This was one of the first things that hit me as well when I started testing Plates for cross browser compatibility. To tackle this issue I have added a map#className alias which maps directly to map#class.

This fix should land in master soon, so I thought I'd give you and heads up on this :)

3rd-Eden added a commit that referenced this issue Aug 7, 2012
- Added new polyfills for array#indexOf
- Exposed the Array.isArray in the sameway as the other polyfill
- Now using charAt instead of html[i] as that doesn't work in older browsers
- Wrapped the className alias in quotes as it broke in IE again.
- Updated the browser unit test with some extra polyfills and line break removers
- Updated the browser tests with the new className API instead of class
@3rd-Eden
Copy link
Member

There is now an alias for class, if you need IE7/8 support you can use map.className instead of map.class. The alias landed in master, so I'm closing this. All other IE related issues are solved in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants